Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: audit precondition comments in samples #1856

Open
BrennaEpp opened this issue Jan 13, 2023 · 0 comments
Open

samples: audit precondition comments in samples #1856

BrennaEpp opened this issue Jan 13, 2023 · 0 comments
Assignees
@JesseLovelace
Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.

Comments

@BrennaEpp
Copy link

Please check the samples that have preconditions for:

  • comments that reference "upload" instead of the current operation being performed with the precondition
  • comments that mention "generation" instead of "metageneration", where applicable

See GoogleCloudPlatform/golang-samples#2813 for reference on comparable changes made in Go.
@product-auto-label product-auto-label bot added api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Jan 13, 2023
@BrennaEpp BrennaEpp added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Jan 13, 2023
@tritone tritone added the type: process A process-related concern. May include testing, release, or the like. label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JesseLovelace JesseLovelace

Labels
api: storage Issues related to the googleapis/java-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tritone @BrennaEpp @JesseLovelace