Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow cancelling a resumable upload #2510

Open
benjaminp opened this issue Apr 24, 2024 · 1 comment
Open

allow cancelling a resumable upload #2510

benjaminp opened this issue Apr 24, 2024 · 1 comment
Labels
api: storage Issues related to the googleapis/java-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@benjaminp
Copy link

Thanks for stopping by to let us know something could be better!

Is your feature request related to a problem? Please describe.
The underlying resumable upload API allows canceling an upload. However, the WriteChannel returned by the Storage.writer methods has no way to cancel the upload.

Describe the solution you'd like
Add an API like cancel to the object returned from Storage.write.

Describe alternatives you've considered
n/a

Additional context
Any other context or screenshots about the feature request.

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Apr 24, 2024
@BenWhitehead BenWhitehead added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Apr 24, 2024
@BenWhitehead
Copy link
Collaborator

This is a shortcoming we are aware of, but haven't yet implemented it (we're having to tease apart some things due to the fact WriteChannel us used by more than just GCS).

Some good news, resumable uploads will be automatically reaped by GCS one week after they are created if they are not finalized. In order to not finalize, simply never call writer#close()

Unfortunately I don't have an estimated of when we will be able to provide a cancel or abort for a resumable upload.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants