Skip to content

Conversation

BenWhitehead
Copy link
Collaborator

FileChannel.transferTo first checks if the destination is open. Our tests didn't catch this before because they did not probe openness before writing bytes.

…d.isOpen()

FileChannel.transferTo first checks if the destination is open. Our tests didn't catch this before because they did not probe openness before writing bytes.
@BenWhitehead BenWhitehead requested a review from a team as a code owner September 22, 2025 19:05
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/java-storage API. labels Sep 22, 2025
@BenWhitehead BenWhitehead merged commit aa90468 into main Sep 22, 2025
25 checks passed
@BenWhitehead BenWhitehead deleted the fix/appendable/isOpen branch September 22, 2025 20:16
nidhiii-27 pushed a commit to nidhiii-27/java-storage that referenced this pull request Oct 6, 2025
…d.isOpen() (googleapis#3302)

FileChannel.transferTo first checks if the destination is open. Our tests didn't catch this before because they did not probe openness before writing bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants