Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add table name to default index name #182

Merged
merged 5 commits into from
Jul 15, 2024
Merged

feat: Add table name to default index name #182

merged 5 commits into from
Jul 15, 2024

Conversation

duwenxin99
Copy link
Contributor

@duwenxin99 duwenxin99 commented Jul 11, 2024

Add table name as prefix to default index name upon index creation to avoid conflicting default index names for different tables.

  1. Change DEFAULT_INDEX_NAME to DEFAULT_INDEX_NAME_SUFFIX.
  2. Change index_name default in the BaseIndex class to None.
  3. In aapply_vector_index(), check if the index_name field is None and if so, give it a default index name (table_name + DEFAULT_INDEX_NAME_SUFFIX).

@duwenxin99 duwenxin99 requested review from a team as code owners July 11, 2024 23:10
@product-auto-label product-auto-label bot added the api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API. label Jul 11, 2024
@duwenxin99 duwenxin99 marked this pull request as draft July 11, 2024 23:13
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@duwenxin99 duwenxin99 marked this pull request as ready for review July 12, 2024 15:43
@duwenxin99 duwenxin99 requested a review from averikitsch July 12, 2024 19:49
@averikitsch averikitsch merged commit 5e746ce into main Jul 15, 2024
13 checks passed
@averikitsch averikitsch deleted the table branch July 15, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants