Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docstring to all methods #187

Merged
merged 17 commits into from
Jul 22, 2024
Merged

docs: Add docstring to all methods #187

merged 17 commits into from
Jul 22, 2024

Conversation

duwenxin99
Copy link
Contributor

@duwenxin99 duwenxin99 commented Jul 17, 2024

add docstring to all methods

@duwenxin99 duwenxin99 requested a review from averikitsch July 17, 2024 14:47
@duwenxin99 duwenxin99 requested review from a team as code owners July 17, 2024 14:47
@product-auto-label product-auto-label bot added the api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API. label Jul 17, 2024
@duwenxin99 duwenxin99 force-pushed the docstring branch 2 times, most recently from 60acad2 to 5877eff Compare July 17, 2024 17:01
Copy link

conventional-commit-lint-gcf bot commented Jul 17, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@duwenxin99 duwenxin99 marked this pull request as draft July 17, 2024 17:06
@duwenxin99 duwenxin99 changed the title feat: Support IAM account override docs: Add docstring to all methods Jul 17, 2024
@duwenxin99 duwenxin99 marked this pull request as ready for review July 18, 2024 16:38
Copy link
Collaborator

@averikitsch averikitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please see comments.

src/langchain_google_alloydb_pg/chat_message_history.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/engine.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/engine.py Outdated Show resolved Hide resolved
src/langchain_google_alloydb_pg/engine.py Outdated Show resolved Hide resolved
duwenxin99 and others added 3 commits July 22, 2024 11:51
Co-authored-by: Averi Kitsch <akitsch@google.com>
Co-authored-by: Averi Kitsch <akitsch@google.com>
Co-authored-by: Averi Kitsch <akitsch@google.com>
@duwenxin99 duwenxin99 merged commit 518581e into main Jul 22, 2024
13 checks passed
@duwenxin99 duwenxin99 deleted the docstring branch July 22, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants