Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: added example for chat message history with omni #191

Merged
merged 9 commits into from
Sep 13, 2024
Merged

docs: added example for chat message history with omni #191

merged 9 commits into from
Sep 13, 2024

Conversation

vishwarajanand
Copy link
Contributor

@vishwarajanand vishwarajanand commented Jul 21, 2024 •
edited
Loading

@product-auto-label product-auto-label bot added the api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API. label Jul 21, 2024
@vishwarajanand vishwarajanand marked this pull request as ready for review July 29, 2024 04:56
@vishwarajanand vishwarajanand requested review from a team as code owners July 29, 2024 04:56
jackwotherspoon
jackwotherspoon previously requested changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@jackwotherspoon jackwotherspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this PR should also use docs: prefix over feat: as feat is reserved to features in the actual package and not documentation.

docs/chat_message_history.ipynb Outdated Show resolved Hide resolved
@vishwarajanand vishwarajanand changed the title feat: added example for chat message history with omni docs: added example for chat message history with omni Jul 29, 2024
@vishwarajanand @jackwotherspoon
nit: resolve pr comments
ead243e 
Co-authored-by: Jack Wotherspoon <jackwoth@google.com>
averikitsch
averikitsch reviewed Sep 13, 2024
View reviewed changes
docs/chat_message_history.ipynb Outdated Show resolved Hide resolved
docs/vector_store.ipynb Outdated Show resolved Hide resolved
@averikitsch averikitsch added the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2024
@averikitsch averikitsch merged commit 2e6809f into main Sep 13, 2024
13 checks passed
@averikitsch averikitsch deleted the chat_message_history_omni branch September 13, 2024 18:21
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Sep 13, 2024
@release-please release-please bot mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

@jackwotherspoon jackwotherspoon Awaiting requested review from jackwotherspoon

Assignees

@averikitsch averikitsch

Labels
api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vishwarajanand @averikitsch @jackwotherspoon