Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added pg to alloy migration guide #249

Merged
merged 67 commits into from
Oct 8, 2024
Merged

Conversation

twishabansal
Copy link
Contributor

No description provided.

src/langchain_google_alloydb_pg/utils/pgvector_migrator.py Outdated Show resolved Hide resolved
samples/migrations/pg_to_alloy.md Outdated Show resolved Hide resolved
samples/migrations/pg_to_alloy.md Outdated Show resolved Hide resolved
samples/migrations/pg_to_alloy.md Outdated Show resolved Hide resolved
samples/migrations/pg_to_alloy.md Outdated Show resolved Hide resolved
samples/migrations/pg_to_alloy.md Outdated Show resolved Hide resolved
samples/migrations/pg_to_alloy.md Outdated Show resolved Hide resolved
samples/migrations/pg_to_alloy.md Outdated Show resolved Hide resolved
samples/migrations/pg_to_alloy.md Outdated Show resolved Hide resolved
await amigrate_pgvector_collection(
engine,
collection_name="collection_name",
vector_store=vector_store,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could point out that if they are moving to a different instance or database they could use different engines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not yet have functionality to allow users to migrate across databases. Should we add it?

@twishabansal twishabansal marked this pull request as ready for review October 1, 2024 08:49
@twishabansal twishabansal requested review from a team as code owners October 1, 2024 08:49
@averikitsch
Copy link
Collaborator

@twishabansal twishabansal merged commit 3ee3601 into main Oct 8, 2024
11 checks passed
@twishabansal twishabansal deleted the pg_migration_guide branch October 8, 2024 18:46
dishaprakash pushed a commit that referenced this pull request Oct 16, 2024
* feat: Added migrator module for PGToAlloy

* Allow ids of all types

* Rearrange methods

* Add async tests

* Fixed lint

* Made tests more robust

* Fixed tests

* Lint fix

* Changed method and class names

* Used fetchone instead of fetchall

* Fixed typos/formatting

* Added public and private params

* Fixed formatting

* Clean code

* Remove loop and run_in_sync

* Remove unused imports

* Hardcoded collections and embeddings tables

* Minor fix

* Lint fix

* Created tables

* Users give column names instead of defining columns

* Removed extra migrator class

* Fixed lint errors

* Minor fix: Does not work

* Changed insert queries

* Added data batching

* Changed indentation to tabs

* Minor cleanup

* Remove pgvector_migrator from init

* Await all insert tasks at once

* Fixed linting errors

* Corrected docstrings

* Made interface similar to vector store customisation

* Changed docstrings

* Corrected error

* Moved sql statements

* Migrate methods take vector store objects

* Sqlalchmey directly yields data batches

* Removed unused imports

* lint

* Lint fix

* code cleanup

* lint

* Code cleanup

* docs: Added pg to alloy migration guide

* small change

* Update samples/migrations/pg_to_alloy.md

Co-authored-by: Averi Kitsch <akitsch@google.com>

* Small changes

* Small change

* Small change

* Changed to correct file

* Deleted migrator code

* Doc cleanup

* Small change

* Added info on how to use search methods without data migration

* Outlined connection simplicity

* corrected docs

* Dedup vector store and destination table

* better naming

* Added docs in content table

---------

Co-authored-by: Averi Kitsch <akitsch@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: alloydb Issues related to the googleapis/langchain-google-alloydb-pg-python API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants