Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: Cannot find module 'semver' #357

Closed
aronsuarez opened this issue Sep 22, 2018 · 5 comments
Closed

Error: Cannot find module 'semver' #357

aronsuarez opened this issue Sep 22, 2018 · 5 comments
Assignees
@schmidt-sebastian
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@aronsuarez
Copy link

Environment details

  • OSX 10.13.6 and GCF with nodejs8
  • Node.js version: 8.12.0
  • npm version: 6.4.1
  • @google-cloud/firestore version: 0.17.0

Steps to reproduce

  1. Try run a any query against firestore
  2. Get "Error: Cannot find module 'semver'"

I god the same error when i deply to GCF europe-west1, when i change the library back to 0.16.0 all works fine.

Thanks!
@lucascaro
Copy link

@aronsuarez I had the same issue just now, why did you close it? did the problem get resolved? looks like semver is a missing dependency? (at least not working with npm 6.x)

@KidkArolis
Copy link

KidkArolis commented Oct 11, 2018 •
edited
Loading

I get the same issue, not locally, but when running on google cloud functions.

@aronsuarez
Copy link
Author

@lucascaro Sorry about that i have closed the wrong issue.

I have still this issue, only 0.16.1 works.

@JustinBeckwith JustinBeckwith added triage me I really want to be triaged. 🚨 This issue needs some love. labels Oct 12, 2018
@schmidt-sebastian
Copy link
Contributor

This should have been addressed with googleapis/gax-nodejs@39e38ee#diff-b9cfc7f2cdf78a7f4b91a753d10865a2. It hasn't been included in a release yet, but I am going to try to push out a release by the end of the week. Thanks!

@JustinBeckwith JustinBeckwith added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Oct 15, 2018
@JustinBeckwith JustinBeckwith removed 🚨 This issue needs some love. triage me I really want to be triaged. labels Oct 15, 2018
@schmidt-sebastian schmidt-sebastian mentioned this issue Oct 18, 2018
Merged
@schmidt-sebastian
Copy link
Contributor

The release for v0.18 is on its way to NPM.

@ghost ghost removed the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Oct 18, 2018
@snyk-bot snyk-bot mentioned this issue Dec 5, 2019
Open
@google-cloud-label-sync google-cloud-label-sync bot added the api: firestore Issues related to the googleapis/nodejs-firestore API. label Jan 31, 2020
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. 🚨 This issue needs some love. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lucascaro @KidkArolis @JustinBeckwith @aronsuarez @schmidt-sebastian @yoshi-automation