fix: http2: serialize array parameters correctly #492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #480 (the "wrong queryParameters serialization" part)
I noticed that a parameter with type
string[]
in the Google Calendar API was not working as expecting while usinggoogle.options({ http2: true });
. Specifically I was trying to use:I found that the
privateExtendedProperty
parameter was being ignored by the server.I traced the issue to this line. Unlike the
gaxios
request handler (reference), the http2 handler is not calling theparamsSerializer
from the parameters. This function is used to define the correct serialization method for array parameters inapirequest.ts
(reference).My fix uses the
paramsSerializer
passed in from the parameters exactly as is done ingaxios
.