fix: wait for 'drain' as well #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
test/publisher/index.ts
Outdated
| // happen if more messages are queued during the publish(). | ||
| setTimeout(() => { | ||
| publisher.queue.emit('drain'); | ||
| }, 50); |
There was a problem hiding this comment.
This will fail eventually, I can bet :) Maybe use longer timeout?
There was a problem hiding this comment.
This just needs to be on the next tick, really, so I could just change this to nextTick().
alexander-fenster
approved these changes
Sep 21, 2022
feywind
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
feywind
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to end up in a situation where more publishes are pending when publish() is called, but they aren't actually waited for. This adds 'drain' event support to the main publisher queue and waits for 'drain' on all queues before calling it done.
Maybe fixes #1620 🦕