-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove redundant .then() causing unhandled exception #1671
Conversation
Fix copied from: googleapis#1671
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! Please merge it!
CC @feywind @alexander-fenster @hongalex I'd say this is a high priority issue, since without an unhandledException handler the app will just terminate upon receiving an error during an ack |
@garymathews Apologies, I've been OoO and I'm the main maintainer. Hopefully we can get this in quickly. |
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1547 🦕
Note: If you are opening a pull request against a
legacy
branch, PLEASE BE AWARE that we generally won't accept these except for things like important security fixes, and only for a limited time.I'm not sure why
.then()
was added here, it appears to be redundant. But without chaining it will cause an unhandled exception; which is causing #1547.Here's an example of an uncaught exception being thrown when chaining isn't used: