Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for gRPC client-side compression #1743

Open
feywind opened this issue Jun 2, 2023 · 1 comment
Open

Support for gRPC client-side compression #1743

feywind opened this issue Jun 2, 2023 · 1 comment
Assignees
@feywind
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@feywind
Copy link
Collaborator

feywind commented Jun 2, 2023

This should add:

  • A min size flag, below which the compression won't happen
  • A flag that makes its way down into gRPC to enable compression for >min size
  • A sample showing how to enable it

ref: 226595447
@feywind feywind added priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jun 2, 2023
@feywind feywind self-assigned this Jun 2, 2023
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/nodejs-pubsub API. label Jun 2, 2023
@feywind feywind added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 2, 2024
@feywind
Copy link
Collaborator Author

feywind commented May 2, 2024

Currently waiting on improved grpc-js support for toggling compression per message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feywind feywind

Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@feywind