-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: node 12 deprecation #1774
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feywind
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Jul 19, 2023
Warning: This pull request is touching the following templated files:
|
product-auto-label
bot
added
the
api: pubsub
Issues related to the googleapis/nodejs-pubsub API.
label
Jul 19, 2023
This was referenced Jul 19, 2023
This is moved into the googleapis repo now, will re-open a new PR. |
feywind
added a commit
that referenced
this pull request
Aug 2, 2023
* feat!: node 12 eos (#1774) - moving to googleapis * feat!: bring in typing interface for Subscription events * feat!: gax 4 updates - some of this will be regen'd, just testing * fix!(deps): update dependency google-gax to v4 (#1780) * fix!(deps): update dependency google-auth-library to v9 (#1776) Co-authored-by: Megan Potter <57276408+feywind@users.noreply.github.com> * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: revert incorrect owlbot change * deps!: update dependencies and kokoro files * build: samples package.json should use the new major * fix!: manually update testIam methods.. not sure why these didn't update * build: make samples always use current version; update to 4.0.0 * build: update check config * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * build: let sample tests drive npm pack --------- Co-authored-by: Mend Renovate <renovate@whitesourcesoftware.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Aug 3, 2023
🤖 I have created a release *beep* *boop* --- ## [4.0.0](https://togithub.com/googleapis/nodejs-pubsub/compare/v3.7.3...v4.0.0) (2023-08-03) ### ⚠ BREAKING CHANGES * node 12 eos ([#1774](https://togithub.com/googleapis/nodejs-pubsub/issues/1774)) (#1784) ### Features * Node 12 eos ([#1774](https://togithub.com/googleapis/nodejs-pubsub/issues/1774)) ([#1784](https://togithub.com/googleapis/nodejs-pubsub/issues/1784)) ([47b83c1](https://togithub.com/googleapis/nodejs-pubsub/commit/47b83c18c543a7c8763256f79927a7340db56568)) ### Bug Fixes * Fix typings for IAM methods ([#1785](https://togithub.com/googleapis/nodejs-pubsub/issues/1785)) ([9a6bdbc](https://togithub.com/googleapis/nodejs-pubsub/commit/9a6bdbce952c81cb1a43fecbce16a3e3ab0f1420)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the googleapis/nodejs-pubsub API.
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently just a placeholder PR for efforts to push out a new major that drops Node 12 support and pulls in a couple of minor breaking changes for typings, and a new gax.