Lease management settings should be consolidated in one place #1914
Assignees
Labels
api: pubsub
Issues related to the googleapis/nodejs-pubsub API.
priority: p3
Desirable enhancement or fix. May not be included in next release.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
hongalex
added
type: feature request
product-auto-label
bot
added
the
api: pubsub
|
As discussed elsewhere, the settings can't be changed until a breaking major. The lease manager changes are planned for an internals cleanup effort. |
|
Kinda looks like the lease manager separation is going to help with this issue, too: So I might do that sooner rather than later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, controlling min/max ack deadline is done in SubscriberOptions, but configuring the total extension (for a message's ack deadline) is in FlowControlOptions.
These are related settings and should be in the same place.
Separately, flow control options being in a the
lease-manager.tsfile seems strange, since lease management should only concern itself with modacks rather than flow/concurrency control.The text was updated successfully, but these errors were encountered: