feat: implement object retention lock for bucket / files #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
ddelgrosso1
force-pushed
the
object-retention
branch
3 times, most recently
from
0a04375
to
955587f
Compare
ddelgrosso1
force-pushed
the
object-retention
branch
from
955587f
to
cc34303
Compare
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
JesseLovelace
approved these changes
Nov 22, 2023
| @@ -423,6 +423,7 @@ export interface FileMetadata extends BaseMetadata { | |||
| }; | |||
| customTime?: string; | |||
| eventBasedHold?: boolean | null; | |||
| readonly eventBasedHoldReleaseTime?: string; | |||
There was a problem hiding this comment.
Where do we use/set this?
There was a problem hiding this comment.
It is not user setable. It is a field that will be added as a fast follow that is only returned if an event-based hold was released.
danielbankhead
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2349 🦕