Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not set customEndpoint if apiEndpoint === default #2460

Merged
merged 1 commit into from
May 8, 2024
Merged

fix: Do not set customEndpoint if apiEndpoint === default #2460

merged 1 commit into from
May 8, 2024

Conversation

danielbankhead
Copy link
Contributor

🦕

@danielbankhead danielbankhead requested review from a team as code owners May 7, 2024 21:55
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels May 7, 2024
ddelgrosso1
ddelgrosso1 reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Was there an associated problem with this?

@danielbankhead
Copy link
Contributor Author

LGTM. Was there an associated problem with this?

Nope! I think it would be a minor, but useful feature for universeDomain users

@danielbankhead danielbankhead merged commit b4dbd73 into main May 8, 2024
19 checks passed
@danielbankhead danielbankhead deleted the api-endpoint-check branch May 8, 2024 17:21
@release-please release-please bot mentioned this pull request May 8, 2024
Merged
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
@kazimanzurrashid kazimanzurrashid mentioned this pull request Jul 17, 2024
Closed
This was referenced Jul 27, 2024
Open
Open
@polly-parrot polly-parrot mentioned this pull request Aug 3, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
This was referenced Sep 3, 2024
Open
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 9, 2024
Open
This was referenced Sep 12, 2024
Open
Open
Open
Open
Open
This was referenced Sep 19, 2024
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddelgrosso1 ddelgrosso1 ddelgrosso1 approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielbankhead @ddelgrosso1 @d-goog