Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add support for 'skipIfExists' option for downloadMany #2526

Merged
merged 17 commits into from
Sep 20, 2024

Conversation

thiyaguk09
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #

thiyaguk09 and others added 17 commits September 6, 2024 15:26
…elds'-to-getFiles

feat(storage):  add support for 'fields' query parameter to getFiles
…elds'-to-getFiles

build: fix path-to-regexp to older version due to node 14 requirement
…elds'-to-getFiles

Remove unnecessary sample code
Node Transfer Manager: add support for 'skipIfExists' option for
downloadMany
…dMany-in-transfer-manager

feat(storage): add support for 'skipIfExists' option for downloadMany
@thiyaguk09 thiyaguk09 requested review from a team as code owners September 19, 2024 10:13
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Sep 19, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 19, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 19, 2024
Copy link
Contributor

@ddelgrosso1 ddelgrosso1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for tackling this.

@danielduhh danielduhh merged commit 729efb2 into googleapis:main Sep 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants