Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

Python, Ruby: use protoGenPackageDeps #135

Open
jmuk opened this issue Sep 23, 2016 · 6 comments
Open

Python, Ruby: use protoGenPackageDeps #135

jmuk opened this issue Sep 23, 2016 · 6 comments
Assignees

Comments

@jmuk
Copy link
Contributor

jmuk commented Sep 23, 2016

--proto_gen_pkg_dep flag has been added by @garrettjonesgoogle for mixin support, but it's not yet used for other langauges. Especially Python and Ruby package template should use them for additional dependencies.

@jmuk
Copy link
Contributor Author

jmuk commented Sep 23, 2016

Cc: @geigerj

@landrito
Copy link
Contributor

landrito commented Oct 4, 2016

Would a simple map between proto_gen_pkg_dep to package name for each language suffice or should more sophisticated logic be used?

@garrettjonesgoogle
Copy link
Member

proto_gen_pkg_dep is just supposed to refer to the api_name used in the consumed package. In general, this just means prefixing "grpc-" (for Java).

@landrito
Copy link
Contributor

landrito commented Oct 4, 2016

Ah I see. I didn't realize that this was the case for Python and Ruby as well.

So should the assumption be to prefix with "grpc-" unless it is google-common-protos or otherwise specified?

@garrettjonesgoogle
Copy link
Member

Yeah. FYI in Java, we even do the same thing for google-common-protos :-)

@landrito
Copy link
Contributor

landrito commented Oct 4, 2016

Gotcha! Thanks for the clarification!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants