This repository has been archived by the owner on Jan 26, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Python, Ruby: use protoGenPackageDeps #135
Comments
Cc: @geigerj |
Would a simple map between proto_gen_pkg_dep to package name for each language suffice or should more sophisticated logic be used? |
proto_gen_pkg_dep is just supposed to refer to the api_name used in the consumed package. In general, this just means prefixing "grpc-" (for Java). |
Yeah. FYI in Java, we even do the same thing for google-common-protos :-) |
Gotcha! Thanks for the clarification! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
--proto_gen_pkg_dep
flag has been added by @garrettjonesgoogle for mixin support, but it's not yet used for other langauges. Especially Python and Ruby package template should use them for additional dependencies.The text was updated successfully, but these errors were encountered: