Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

gRPC packages: declared proto package, directory structure #48

Open
geigerj opened this issue Jun 17, 2016 · 0 comments
Open

gRPC packages: declared proto package, directory structure #48

geigerj opened this issue Jun 17, 2016 · 0 comments

Comments

@geigerj
Copy link
Contributor

geigerj commented Jun 17, 2016

cc: @bjwatson @tbetbetbe

If you attempt to build a Python gRPC package for foo/bar/service.proto, it generates the Python package foo.bar.service, even if service.proto declares a different package like

// service.proto
syntax = proto3;

package foo.baz

In this case, GAPIC will attempt to generate an import of service as the Python module foo.baz.service rather than foo.bar.service.

It might be nice if packman could detect this discrepancy and either

  • Issue a warning to the console, or
  • Fix the protoc output so that it uses the declared package foo.baz
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant