Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix import error string showing wrong pip install path #1076

Merged
merged 4 commits into from
Mar 14, 2022
Merged

fix: Fix import error string showing wrong pip install path #1076

merged 4 commits into from
Mar 14, 2022

Conversation

taiseiak
Copy link
Contributor

Fix import error showing python-aiplatform instead of google-cloud-aiplatform.

parthea
parthea approved these changes Mar 12, 2022
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor observation, otherwise LGTM

google/cloud/aiplatform/explain/lit.py Outdated Show resolved Hide resolved
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 12, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 12, 2022
taiseiak and others added 2 commits March 12, 2022 15:11
@taiseiak @parthea
Update google/cloud/aiplatform/explain/lit.py
206c86f 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@sasha-gitg
Merge branch 'main' into main
7a5bed1
@sasha-gitg sasha-gitg added the automerge Merge the pull request once unit tests and other checks pass. label Mar 14, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 74ffa19 into googleapis:main Mar 14, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 14, 2022
@release-please release-please bot mentioned this pull request Mar 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@taiseiak @parthea @sasha-gitg @yoshi-kokoro