Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add samples for Metadata context list, get, and create #1525

Conversation

SinaChavoshi
Copy link
Contributor

Note that this cl will fail until the dependancies are checked in.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@SinaChavoshi SinaChavoshi requested review from a team as code owners July 20, 2022 07:05
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jul 20, 2022
@snippet-bot
Copy link

snippet-bot bot commented Jul 20, 2022

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. labels Jul 20, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Jul 20, 2022
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor comments.

SinaChavoshi and others added 5 commits July 25, 2022 10:29
…est.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
…test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
…test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
…est.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
@product-auto-label product-auto-label bot removed the size: m Pull request size is medium. label Jul 25, 2022
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jul 25, 2022
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SinaChavoshi SinaChavoshi merged commit d913e1d into googleapis:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants