Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support ResourceName with Version. #1609

Merged
merged 4 commits into from
Aug 24, 2022
Merged

feat: Support ResourceName with Version. #1609

merged 4 commits into from
Aug 24, 2022

Conversation

SinaChavoshi
Copy link
Contributor

@SinaChavoshi SinaChavoshi commented Aug 23, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Aug 23, 2022
@SinaChavoshi SinaChavoshi marked this pull request as ready for review August 23, 2022 22:44
@SinaChavoshi SinaChavoshi requested a review from a team as a code owner August 23, 2022 22:44
jialuzh
jialuzh reviewed Aug 24, 2022
View reviewed changes
Copy link
Contributor

@jialuzh jialuzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a corresponding unit test for this change?

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Aug 24, 2022
@SinaChavoshi
Copy link
Contributor Author

Done.

@SinaChavoshi SinaChavoshi merged commit 737dc2b into googleapis:main Aug 24, 2022
@release-please release-please bot mentioned this pull request Aug 24, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 25, 2023
Closed
@release-please release-please bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jialuzh jialuzh jialuzh approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SinaChavoshi @jialuzh