Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error when only log confusion matrix or ROC curve through log_classification_metrics #1742

Merged
merged 1 commit into from
Oct 20, 2022
Merged

fix: Error when only log confusion matrix or ROC curve through log_classification_metrics #1742

merged 1 commit into from
Oct 20, 2022

Conversation

jaycee-li
Copy link
Contributor

@jaycee-li jaycee-li commented Oct 19, 2022 •
edited
Loading

Bug:
get error local variable 'confidence_metrics' referenced before assignment
if users only log confusion matrix through log_classification_metrics

@jaycee-li jaycee-li requested a review from a team as a code owner October 19, 2022 23:32
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Oct 19, 2022
sasha-gitg
sasha-gitg approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@sasha-gitg sasha-gitg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference to add unit tests that test:

  1. Passing just labels and metrics
  2. Passing just fpr,tpr,and threshold

Can be added in a follow up PR to unblock this fix.

jialuzh
jialuzh approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@jialuzh jialuzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, let's add some tests to cover this bug.

@jaycee-li jaycee-li merged commit 3588526 into googleapis:main Oct 20, 2022
@release-please release-please bot mentioned this pull request Oct 20, 2022
Merged
@release-please release-please bot mentioned this pull request Jun 8, 2023
Closed
@release-please release-please bot mentioned this pull request Aug 25, 2023
Closed
@release-please release-please bot mentioned this pull request Sep 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasha-gitg sasha-gitg sasha-gitg approved these changes

@jialuzh jialuzh jialuzh approved these changes

Assignees
No one assigned
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaycee-li @jialuzh @sasha-gitg