Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: _TrainingScriptPythonPackager to support folders #812

Merged
merged 8 commits into from
Jan 13, 2022

Conversation

ivanmkc
Copy link
Contributor

@ivanmkc ivanmkc commented Nov 1, 2021

Allow _TrainingScriptPythonPackager to support a folder in addition to a single script.

Related to: https://b.corp.google.com/issues/204787988

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Nov 1, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2021
@nicain
Copy link
Contributor

nicain commented Nov 8, 2021

@ivanmkc I am assigning as owner of this PR; feel free to ping reviewers as needed to make sure the review process progresses in a timely fashion, or provide guidance on a who might better own the process of getting the PR reviewed, passing continuous testing, and merged. Reach out if you have questions.

@nicain nicain assigned ivanmkc and unassigned andrewferlitsch Nov 8, 2021
@nicain nicain added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Nov 9, 2021
@sasha-gitg sasha-gitg requested review from morgandu and removed request for sasha-gitg November 11, 2021 14:18
@morgandu
Copy link
Contributor

Please fix the Presubmit test failures before merge.

Allow _TrainingScriptPythonPackager to support a folder in addition to a single script.
@ivanmkc ivanmkc merged commit 3aec6a7 into main Jan 13, 2022
@ivanmkc ivanmkc deleted the ivanmkc--package-folders branch January 13, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants