-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: increase upper limit for protobuf 5.X versions #212
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I have the CLA signed with my personal email... but I can't change it to my GitHub email which is |
Thanks for opening a PR, @RobPasMue! Please see the CLA troubleshooting section here: I'm wondering if deprecation warnings for Please allow some time for me to discuss with my colleagues on the best approach. In the meantime, if presubmits pass, we could proceed with your proposed change. A separate PR could be prepared at a later time to deprecate/drop protobuf 3.x/4.x and eventually upgrade python-api-common-protos/noxfile.py Lines 23 to 27 in 3940a04
|
That'd be great @parthea - let me know if I can be of any help! |
Hi @parthea! Any news here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RobPasMue!
Thanks @parthea! Any reason why the workflow is not running? |
@RobPasMue, For the |
Awesome, thanks! Really appreciated |
Hello, when will this make it onto PyPi? Currently still showing 1.63.0 with the incorrect <5.0 protobuf dependency |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #211 🦕