Address review comments

googleapis · Oct 13, 2023 · c7f63bd · c7f63bd
1 parent 7ec7832
commit c7f63bd
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/google/api_core/bidi.py b/google/api_core/bidi.py
@@ -265,6 +265,9 @@ def add_done_callback(self, callback):
  self._callbacks.append(callback)
 
  def _on_call_done(self, future):
+ # Note that grpc's "future" here is also a grpc.RpcError.
+ # `grpc.RpcError` is also `grpc.call` based on
+ # https://github.com/grpc/grpc/issues/10885#issuecomment-302651331
  for callback in self._callbacks:
  callback(future)