feat: add automatic logging config to support debug logging #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
ohmayr
force-pushed
the
debug-logging
branch
from
f8cb7fc to
ff594d3
Compare
ohmayr
force-pushed
the
debug-logging
branch
from
ff594d3 to
7b1605c
Compare
vchudnov-g
reviewed
Nov 22, 2024
ohmayr
changed the title
vchudnov-g
reviewed
Nov 26, 2024
parthea
reviewed
Nov 26, 2024
parthea
reviewed
Nov 26, 2024
parthea
reviewed
Nov 26, 2024
parthea
reviewed
Nov 26, 2024
vchudnov-g
reviewed
Nov 26, 2024
product-auto-label
bot
added
size: l
vchudnov-g
approved these changes
Nov 27, 2024
parthea
approved these changes
Nov 27, 2024
parthea
reviewed
Nov 27, 2024
parthea
reviewed
Nov 28, 2024
| # Fields to be included in the StructuredLogFormatter. | ||
| # | ||
| # TODO(https://github.com/googleapis/python-api-core/issues/761): Update this list to support additional logging fields. | ||
| _recognized_logging_fields = [ |
There was a problem hiding this comment.
One thing to note is that users will need to update google-api-core to get any additional logging fields in the future.
There was a problem hiding this comment.
This is true. Any fields that we add in the future will require users to update google-api-core.
parthea
reviewed
Nov 28, 2024
parthea
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement automatic logging config to allow users to enable debug logging via an environment variable.
Fixes b/381099872