Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak in bidi resources #769

Open
daniel-sanche opened this issue Dec 16, 2024 · 2 comments · May be fixed by #770
Open

Memory leak in bidi resources #769

daniel-sanche opened this issue Dec 16, 2024 · 2 comments · May be fixed by #770
Assignees
@vchudnov-g
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@daniel-sanche
Copy link
Contributor

daniel-sanche commented Dec 16, 2024 •
edited
Loading

Reported in pyhton-firestore: googleapis/python-firestore#985

It looks like some of the resources in BackgroundConsumer and ResumableBidiRpc are not being cleaned up properly on close, and preventing garbage collection. I ran the attached script, and can confirm I see the same thing

I opened #770 to address the issue, but maybe someone with more familiarity with the classes can take a look as well
@daniel-sanche daniel-sanche linked a pull request Dec 16, 2024 that will close this issue
Open
@daniel-sanche daniel-sanche mentioned this issue Dec 16, 2024
Open
@vchudnov-g vchudnov-g added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 18, 2024
@vchudnov-g
Copy link
Contributor

Thanks for reporting this and proposing a fix, @daniel-sanche! The "attached script" you refer to is the "Code example" in googleapis/python-firestore#985, correct?

@daniel-sanche
Copy link
Contributor Author

Yes, that's the one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vchudnov-g vchudnov-g

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: memory leak in bidi classes googleapis/python-api-core
2 participants
@daniel-sanche @vchudnov-g