Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up error handling to pass through errors instead of catching/rethrowing #265

Open
tswast opened this issue Mar 26, 2019 · 3 comments
Open

Clean-up error handling to pass through errors instead of catching/rethrowing #265

tswast opened this issue Mar 26, 2019 · 3 comments
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.

Comments

@tswast
Copy link
Collaborator

tswast commented Mar 26, 2019

There have been several StackOverflow questions about GenericGBQException.

We should have a troubleshooting document that covers:

  • Common exceptions that may occur.
  • How to import them to catch them.
  • Best practices for handling them.

Side note: We may want to reconsider catching Google API exceptions at all and just letting them pass through.
@tswast tswast added the docs label Mar 26, 2019
@max-sixty
Copy link
Contributor

There have been several StackOverflow questions about GenericGBQException.

Awesome, great perception

Side note: We may want to reconsider catching Google API exceptions at all and just letting them pass through.

👍
Is there a compelling reason for catching and rethrowing?

@tswast
Copy link
Collaborator Author

tswast commented Mar 26, 2019

Is there a compelling reason for catching and rethrowing?

I'm having trouble thinking of one.

@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Aug 9, 2019
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Jul 17, 2021
@meredithslota
Copy link
Contributor

Converting this to a feature request to pass through server-side errors instead of catching/handling them with custom exceptions.

@meredithslota meredithslota changed the title DOC: Document exceptions and how to import them Clean-up error handling to pass through errors instead of catching/rethrowing Aug 23, 2023
@meredithslota meredithslota added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. and removed type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. docs labels Aug 23, 2023
@meredithslota meredithslota mentioned this issue Aug 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tswast @meredithslota @max-sixty