Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: grouping sets, rollup and cube rendering issue #1019

Closed
wants to merge 9 commits into from
Closed

fix: grouping sets, rollup and cube rendering issue #1019

wants to merge 9 commits into from

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Jan 31, 2024

This PR:

  • Introduces Grouping Sets, Rollup and Cube compatibility with SQLAlchemy compiler
  • Addresses internal and github customer issues
  • Should not be merged before SQLAlchemy 2.0 migration is merged into main (this PR is only compatible with 1.4+)

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #879 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. labels Jan 31, 2024
@kiraksi kiraksi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 31, 2024
@kiraksi kiraksi changed the base branch from main to development-build-v1.11.0.dev2 February 1, 2024 18:14
@kiraksi kiraksi added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2024
@kiraksi kiraksi added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2024
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 1, 2024
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2024
@kiraksi kiraksi marked this pull request as ready for review February 6, 2024 07:45
@kiraksi kiraksi requested review from a team as code owners February 6, 2024 07:45
@kiraksi kiraksi requested review from tswast and chalmerlowe and removed request for a team February 6, 2024 07:45
@kiraksi kiraksi removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 6, 2024
@kiraksi kiraksi changed the title feat: grouping sets, rollup and cube sqla compatibility fix: grouping sets, rollup and cube rendering issue Feb 6, 2024
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2024
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2024
@kiraksi kiraksi requested a review from chalmerlowe February 8, 2024 21:00
chalmerlowe
chalmerlowe approved these changes Feb 12, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiraksi
Copy link
Contributor Author

kiraksi commented Feb 12, 2024

This is now a part of branch development-build-1.11.0.dev3

@kiraksi kiraksi closed this Feb 12, 2024
@tswast tswast mentioned this pull request Apr 2, 2024
Merged
@release-please release-please bot mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@tswast tswast Awaiting requested review from tswast tswast is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery-sqlalchemy API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GROUP BY clause will not properly rendered if there is a function applied column expression
4 participants
@kiraksi @chalmerlowe @parthea @yoshi-kokoro