-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support UPDATE + JOIN in BigQuery dialect #1083
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Pull request size is medium.
api: bigquery
Issues related to the googleapis/python-bigquery-sqlalchemy API.
labels
Jun 6, 2024
Linchin
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 11, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 11, 2024
Linchin
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 11, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 11, 2024
Linchin
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 11, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 11, 2024
Linchin
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 12, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 12, 2024
Linchin
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 12, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 12, 2024
chalmerlowe
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have several comments.
Linchin
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 13, 2024
yoshi-kokoro
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Jun 13, 2024
chalmerlowe
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chalmerlowe
added
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owlbot:run
Add this label to trigger the Owlbot post processor.
labels
Jun 13, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Jun 13, 2024
yoshi-kokoro
removed
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
labels
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigquery
Issues related to the googleapis/python-bigquery-sqlalchemy API.
size: m
Pull request size is medium.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent class
SQLCompiler
doesn't implementupdate_from_clause()
, and thus does not support UPDATE + JOIN. This PR uses the implementation in PostgreSQL to support this.Thanks to @brian-pond for the thorough investigation!
P.S.
We added a
third_party
folder to vendor a code snippet from the postgresql portion of the sqlalchemy code. For future reference, in order to add vendored code, we need to do the following (for the exact change detail, check the content of this PR):sqlalchemy_bigquery_vendored
as the package name instead ofthird_party
becausethird_party
is used in many different placesthird_party
folder, see develop mode does not respect src structure pypa/setuptools#230 (comment)Thanks to @tswast for helping figure out the copyright and code vendoring details 🙂
Fixes #1010 🦕