fix: remove type annotations from _struct.py #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
aribray
added
kokoro:force-run
aribray
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
aribray
added
kokoro:force-run
aribray
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
aribray
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Removed unused imports to satisfy linter.
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
chalmerlowe
reviewed
Feb 2, 2023
setup.py
Outdated
| @@ -46,7 +46,7 @@ def readme(): | |||
|
|
|||
|
|
|||
| extras = dict( | |||
| geography=["GeoAlchemy2", "shapely"], | |||
| geography=["GeoAlchemy2==0.12.5", "shapely"], | |||
There was a problem hiding this comment.
It is not clear why we included a specific version of GeoAlchemy2 in this PR.
Ari is not supporting this task, so I am unable to ask about it.
I am gonna remove it and ensure that tests pass without it.
If tests pass, I recommend we merge.
chalmerlowe
reviewed
Feb 2, 2023
chalmerlowe
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes type annotations from _struct.py
Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)
Fixes #545 🦕