-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Big Query Write append_row retries on Aborted exceptions #315
Comments
The default retry policy is configured across client libraries for all languages in the service specification, and is part of code generated from that repo here. You could use implementation details to change the default policy, e.g.: from google.api_core import exceptions
from google.api_core import retry
_retry_abort_unavailable = retry.if_exception_type(
exceptions.Abort, exceptions.ServiceUnavailable,
)
transport = client.transport
wrapper = transport._wrapped_methods[transport.append_row]
wrapper._retry._predicate = _retry_abort_unavailable Ideally, we would make it possible to do that without using private attributes. |
I believe this will require a change to the One would also need to make sure the queue of unacknowledged requests is re-sent and any duplicate/conflict responses that we get back are ignored properly. |
How about the |
Thanks for stopping by to let us know something could be better!
PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.
Is your feature request related to a problem? Please describe.
I'm using the beta storage write client to upload data to GBQ using append_rows function(v2.6). In production I'm encountering the below error intermittently:
According to the error an retry seems to be the best approach, but currently default retry doesn't retry for this type of exception.
Code reference here.
Describe the solution you'd like
Include retry for Aborted type of exception.
Describe alternatives you've considered
My client code pass in retry that include Aborted exception.
The text was updated successfully, but these errors were encountered: