Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add --no_query_cache option to %%bigquery magics to disable… #1141

Merged
merged 2 commits into from
Feb 16, 2022

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Feb 16, 2022

… query cache

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes internal issue 215520997 🦕

@tswast tswast requested a review from a team February 16, 2022 19:48
@tswast tswast requested a review from a team as a code owner February 16, 2022 19:48
@tswast tswast requested a review from shollyman February 16, 2022 19:48
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Feb 16, 2022
@@ -442,6 +444,12 @@ def _create_dataset_if_necessary(client, dataset_id):
"this option's value in the context bqstorage_client_options."
),
)
@magic_arguments.argument(
"--no_query_cache",
action="store_true",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not understanding what this "store_true" is about, but it seems consistent with the other arguments.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's behavior IPython/Jupyter inherits from argparse https://docs.python.org/3/library/argparse.html#action

The gist is that if this argument is present it'll set args.no_query_cache = True rather than requiring a boolean parameter.

@tswast tswast merged commit 7dd30af into main Feb 16, 2022
@tswast tswast deleted the b215520997-magics-no-cache branch February 16, 2022 23:07
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants