Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up samples/snippets/requirements.txt #1352

Closed
tswast opened this issue Sep 14, 2022 · 1 comment
Closed

Clean-up samples/snippets/requirements.txt #1352

tswast opened this issue Sep 14, 2022 · 1 comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like. wontfix This will not be worked on

Comments

@tswast
Copy link
Contributor

tswast commented Sep 14, 2022

Ideally we'd have some code samples which only require the bare minimum dependencies (no pandas, no google-cloud-bigquery-storage, no protobuf, etc). The samples/snippets directory would be perfect for this, but:

  1. There are a couple of pandas-related samples there which ideally should be moved to a samples/pandas directory.
  2. Likewise, there is a "desktop application" sample https://github.com/googleapis/python-bigquery/blob/main/samples/snippets/user_credentials.py which ideally belongs in its own directory with its own noxfile.py and requirements.txt. This is because it's responsible for the google-auth-oauthlib dependency, which isn't required for any other samples. Maybe we call this directory samples/desktopapp or something?

Related issues:

@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Sep 14, 2022
@product-auto-label product-auto-label bot added api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Sep 14, 2022
@chalmerlowe chalmerlowe added the wontfix This will not be worked on label Jun 7, 2023
@chalmerlowe
Copy link
Collaborator

Added this content to another open ticket #790
Closing this since that ticket now captures the relevant information and this is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like. wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants