Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option to set preserve_ascii_control_characters is not available on load config #1387

Closed
Gaurang033 opened this issue Oct 17, 2022 · 2 comments · Fixed by #1484
Closed

option to set preserve_ascii_control_characters is not available on load config #1387

Gaurang033 opened this issue Oct 17, 2022 · 2 comments · Fixed by #1484
Assignees
@thejaredchapman @Mattix23
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@Gaurang033
Copy link
Contributor

Gaurang033 commented Oct 17, 2022 •
edited
Loading

Environment details

  • OS type and version: windows 10
  • Python version: 3.10
  • pip version: pip 22.0.3
  • google-cloud-bigquery version: Name: google-cloud-bigquery Version: 3.3.3 Summary: Google BigQuery API client library Home-page: https://github.com/googleapis/python-bigquery Author: Google LLC Author-email: googleapis-packages@google.com License: Apache 2.0 Location: c:\users\fki\appdata\roaming\python\python39\site-packages Requires: google-api-core, google-cloud-bigquery-storage, google-cloud-core, google-resumable-media, grpcio, packaging, proto-plus, protobuf, pyarrow, python-dateutil, requests Required-by: bigquery, pandas-gbq

Steps to reproduce

  1. /google/cloud/bigquery/job/load.py LoadJobConfig class does not have a property set preserve_ascii_control_characters options

Work around

job_config._properties["load"]["preserve_ascii_control_characters"] = True
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 17, 2022
@Gaurang033
Copy link
Contributor Author

let me know if you think this needs to be fixed, I can create a pull request for this

@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jan 18, 2023
@tswast
Copy link
Contributor

tswast commented Jan 30, 2023

For reference the REST documentation is here: https://cloud.google.com/bigquery/docs/reference/rest/v2/Job#JobConfigurationLoad.FIELDS.preserve_ascii_control_characters

@Mattix23 Mattix23 mentioned this issue Jan 31, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thejaredchapman thejaredchapman

@Mattix23 Mattix23

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add preserveAsciiControlCharacter to LoadJobConfig googleapis/python-bigquery
4 participants
@tswast @Gaurang033 @thejaredchapman @Mattix23