-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose jobTimeoutMs field in JobConfigurationQuery #1421
Comments
This could be another good project for the apprentices. |
Since this applies to all job configurations, this would be a good fit to add to the _JobConfig base class here:
|
Currently looking at how to work around this issue for users of https://github.com/dbt-labs/dbt-bigquery but solving here is definitely the ideal solution. |
I've started a draft PR (#1656) for this issue. I have tested the the timeout works, but I could use some guidance (pointers to docs) on what is required test wise / how to add the required tests to this. |
@colin-rogers-dbt shipped a fix for us in dbt-labs/dbt-bigquery#902, but to reiterate, this is not the ideal place for the fix. |
+1 on exposing |
At job creation time I want to set a timeout for the job if it takes too long to run. Too many long running queries eat up the slot reservation and significantly deteriorates query performance. Currently we have to manually cancel the queries in the console. I noticed that there is a
jobTimeoutMs
field in the JobConfiguration object. This is not exposed by the Python client but is exposed by other Bigquery clients (Golang). Can we add this to the Python client as well?The alternative would be to have a timer on the client side and manually cancel the request. This feels wasteful considering the feature already exists on the server side and it's just a question of exposing it in the client.
The text was updated successfully, but these errors were encountered: