Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Use logic from BQStorageVersions and PyarrowVersions instead of comparing version strings outside of _helpers #1430

Closed
tswast opened this issue Dec 8, 2022 · 2 comments · Fixed by #1699
Assignees
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.

Comments

@tswast
Copy link
Contributor

tswast commented Dec 8, 2022

Ideally we'd never need to compare PyArrow versions outside of the PyarrowVersions class. We might need to add some additional methods / properties to do this.

Follow-up to https://github.com/googleapis/python-bigquery/pull/1282/files#discussion_r927998418

@tswast tswast added the type: process A process-related concern. May include testing, release, or the like. label Dec 8, 2022
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 8, 2022
@tswast tswast changed the title cleanup: Use logic from PyarrowVersions instead of comparing version strings outside of _helpers cleanup: Use logic from BQStorageVersions and PyarrowVersions instead of comparing version strings outside of _helpers Dec 8, 2022
@tswast
Copy link
Contributor Author

tswast commented Dec 8, 2022

Likewise, a try_import method might be useful on the BQStorageVersions class.

Follow-up to https://github.com/googleapis/python-bigquery/pull/1282/files#discussion_r927998737

@chalmerlowe
Copy link
Collaborator

To sum up, it looks like we wanna do all the following:

  • Move a try: import statement into the BQStorageVersions Class
  • Find any remaining references to version checking and replace with calls to the appropriate methods in the BQStorageVersions Class and/or the PyarrowVersions Class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
3 participants