Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: revise get table labels code sample, add TODO to clean up snipp… #1464

Merged
merged 4 commits into from
Jan 13, 2023
Merged

docs: revise get table labels code sample, add TODO to clean up snipp… #1464

merged 4 commits into from
Jan 13, 2023

Conversation

Mattix23
Copy link
Contributor

…ets.py

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #790 🦕

@Mattix23 Mattix23 requested a review from a team January 13, 2023 17:01
@Mattix23 Mattix23 requested review from a team as code owners January 13, 2023 17:01
@Mattix23 Mattix23 requested review from tswast and kurtisvg January 13, 2023 17:01
@snippet-bot
Copy link

snippet-bot bot commented Jan 13, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 13, 2023
@tswast tswast enabled auto-merge (squash) January 13, 2023 19:34
@tswast tswast merged commit b5ccbfe into main Jan 13, 2023
@tswast tswast deleted the issue790-get_table_label branch January 13, 2023 20:07
@release-please release-please bot mentioned this pull request Jan 13, 2023
Merged
This was referenced Jan 24, 2023
Closed
Closed
Closed
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
@Mattix23 @tswast @abdelmegahedgoogle
docs: revise get table labels code sample, add TODO to clean up snipp… (
00ef22b 
googleapis#1464)

* docs: revise get table labels code sample, add TODO to clean up snippets.py

* added a test with labels

* Update samples/snippets/get_table_labels_test.py

Co-authored-by: Tim Swast <swast@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@kurtisvg kurtisvg Awaiting requested review from kurtisvg kurtisvg is a code owner automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mattix23 @tswast