-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add date, datetime, time, timestamp dtype to to_dataframe #1547
Conversation
3075ecd
to
ef363e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loving it so far.
Would you do me a favor and add a system test with "extreme" values like this one, but instead of looking for "object" dtypes, we pass in the ArrowDtype
?
python-bigquery/tests/system/test_pandas.py
Line 1063 in e1aa921
def test_list_rows_nullable_scalars_extreme_dtypes( |
5a8c0f6
to
ac07193
Compare
ac07193
to
f560802
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
c78c50f
to
e1f7f77
Compare
36f6878
to
c9dbce3
Compare
c9dbce3
to
e321e14
Compare
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1546 🦕