Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add date, datetime, time, timestamp dtype to to_dataframe #1547

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

chelsea-lin
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Fixes #1546 🦕

@chelsea-lin chelsea-lin requested review from a team as code owners April 7, 2023 00:32
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Apr 7, 2023
@chelsea-lin chelsea-lin requested a review from tswast April 7, 2023 00:33
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loving it so far.

Would you do me a favor and add a system test with "extreme" values like this one, but instead of looking for "object" dtypes, we pass in the ArrowDtype?

def test_list_rows_nullable_scalars_extreme_dtypes(

google/cloud/bigquery/table.py Show resolved Hide resolved
@chelsea-lin chelsea-lin requested a review from tswast April 10, 2023 17:30
@chelsea-lin chelsea-lin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2023
@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2023
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2023
@tswast tswast added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 13, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 13, 2023
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_typesmapper branch 3 times, most recently from c78c50f to e1f7f77 Compare April 18, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'date_dtype', 'datetime_dtype', 'time_dtype' and 'timetamp_dtype' to the 'to_dataframe' APIs
4 participants