Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add types to DatasetReference constructor #1601

Merged

Conversation

kserruys
Copy link
Contributor

@kserruys kserruys commented Jun 29, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1598 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jun 29, 2023
@kserruys kserruys marked this pull request as ready for review June 29, 2023 09:33
@kserruys kserruys requested review from a team as code owners June 29, 2023 09:33
@kserruys kserruys requested a review from jainsahab June 29, 2023 09:33
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2023
chalmerlowe
chalmerlowe previously approved these changes Jun 29, 2023
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2023
@chalmerlowe
Copy link
Collaborator

Welp:

We appear to be faced with a mismatch. Doing a run of mypy against the code produces this error:

google/cloud/bigquery/dataset.py:187: error: Argument 1 to "DatasetReference" has incompatible type "Optional[str]"; expected "str"

Feel free to dig into this and see what produces that incompatible type on line 187 and what we might need to do to resolve this issue.

@chalmerlowe chalmerlowe dismissed their stale review June 29, 2023 18:24

tests failed

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 30, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jul 6, 2023
@kserruys kserruys requested a review from chalmerlowe July 12, 2023 13:01
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 13, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Jul 13, 2023
@chalmerlowe
Copy link
Collaborator

@kserruys let's run kokoro and see what kinda results we get from the tests.

@chalmerlowe
Copy link
Collaborator

@kserruys

The two types of prerelease dependency test failures are a known issue that I need to tackle and we can safely ignore them in this case.

The Kokoro test failure relates to the overall test coverage.
It looks like enough has changed in that portion of code by adding a new conditional branch that the Python library coverage feels our tests are not comprehensive enough.

Are you comfortable diving into the test suite to see what needs to be added to the tests to provide coverage for the new conditional?

Comment on lines -180 to +182
elif len(parts) > 2:
else:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here else: covers the same cases as elif len(parts) > 2:

Parameter dataset_id is a string, because of that list parts will always have at least 1 item.
By using else we can reassure pytest-cov that everything is ok.

@kserruys
Copy link
Contributor Author

@kserruys

The two types of prerelease dependency test failures are a known issue that I need to tackle and we can safely ignore them in this case.

The Kokoro test failure relates to the overall test coverage. It looks like enough has changed in that portion of code by adding a new conditional branch that the Python library coverage feels our tests are not comprehensive enough.

Are you comfortable diving into the test suite to see what needs to be added to the tests to provide coverage for the new conditional?

@chalmerlowe

Sure :). I just took a while to find some time to do this.
Please have a look at the updated code. Coverage on my local machine return 100% now.

Regards

@meredithslota meredithslota added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 1, 2023
@meredithslota meredithslota added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2023
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@tswast tswast enabled auto-merge (squash) April 12, 2024 17:19
@tswast tswast added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@tswast tswast added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 12, 2024
@tswast tswast merged commit bf8861c into googleapis:main Apr 12, 2024
18 checks passed
@tswast
Copy link
Contributor

tswast commented Apr 12, 2024

Thanks @kserruys so much for the contribution and for your patience on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type annotations missing on bigqueryDatasetReference
6 participants