Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update multiple samples to change query to query_and_wait #1784

Merged
merged 5 commits into from
Jan 17, 2024
Merged

docs: update multiple samples to change query to query_and_wait #1784

merged 5 commits into from
Jan 17, 2024

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Jan 17, 2024 •
edited
Loading

This PR updates the following samples to use the query_and_wait API:

  • samples/snippets/authorized_view_tutorial.py
  • samples/snippets/simple_app.py
  • samples/snippets/natality_tutorial.py
  • samples/client_query_relax_column.py
  • samples/client_query_add_column.py
  • samples/client_query_w_struct_params.py
  • samples/download_public_data_sandbox.py
  • samples/client_query_destination_table_clustered.py
  • samples/client_query_legacy_sql.py
  • samples/tests/conftest.py

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Jan 17, 2024
@kiraksi kiraksi changed the title docs: update multiple samples for query_and_wait API docs: update multiple samples to change query to query_and_wait Jan 17, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 17, 2024
@kiraksi kiraksi added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 17, 2024
@kiraksi kiraksi marked this pull request as ready for review January 17, 2024 11:49
@kiraksi kiraksi requested review from a team as code owners January 17, 2024 11:49
@kiraksi kiraksi requested review from farhan0102, leahecole and tswast and removed request for leahecole and farhan0102 January 17, 2024 11:49
tswast
tswast requested changes Jan 17, 2024
View reviewed changes
samples/client_query_w_struct_params.py Outdated Show resolved Hide resolved
samples/client_query_legacy_sql.py Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 17, 2024
tswast
tswast approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@tswast tswast enabled auto-merge (squash) January 17, 2024 20:16
@tswast tswast merged commit d1161dd into googleapis:main Jan 17, 2024
18 of 19 checks passed
@release-please release-please bot mentioned this pull request Jan 17, 2024
Merged
@kiraksi kiraksi deleted the samples-update branch January 18, 2024 00:32
This was referenced Jan 30, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kiraksi @tswast