Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pandas 2.0 release candidate #179

Merged
merged 1 commit into from
Mar 29, 2023
Merged

feat: support pandas 2.0 release candidate #179

merged 1 commit into from
Mar 29, 2023

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Mar 29, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #178 🦕

@tswast tswast requested review from a team as code owners March 29, 2023 15:22
@tswast tswast requested a review from GaoleMeng March 29, 2023 15:22
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. labels Mar 29, 2023
@tswast tswast enabled auto-merge (squash) March 29, 2023 15:33
@tswast tswast closed this Mar 29, 2023
auto-merge was automatically disabled March 29, 2023 15:34

Pull request was closed

@tswast tswast reopened this Mar 29, 2023
@tswast tswast enabled auto-merge (squash) March 29, 2023 15:34
@tswast
Copy link
Collaborator Author

tswast commented Mar 29, 2023

Ugh, looks like there's an issue with Actions: https://www.githubstatus.com/

Update - We are still investigating the cause of Actions degradation, we will provide an update when we have one.
Mar 29, 2023 - 14:56 UTC

Update - Actions is now experiencing degraded availability. We are still investigating and will provide an update when we have one.
Mar 29, 2023 - 14:43 UTC

Investigating - We are investigating reports of degraded performance for Actions.
Mar 29, 2023 - 14:21 UTC

Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, am interested in seeing the tests pass in case there is something unforeseen.

@tswast
Copy link
Collaborator Author

tswast commented Mar 29, 2023

Locally, looks all good:

nox > Ran multiple sessions:
nox > * lint: success
nox > * unit-3.7: success
nox > * unit-3.8: success
nox > * unit-3.9: success
nox > * unit-3.10: success
nox > * unit-3.11: success
nox > * unit_prerelease: success
nox > * compliance: success
nox > * compliance_prerelease: success
nox > * cover: success
nox > * lint_setup_py: success
nox > * blacken: success
nox > * docs: success

@tswast tswast closed this Mar 29, 2023
auto-merge was automatically disabled March 29, 2023 18:35

Pull request was closed

@tswast tswast reopened this Mar 29, 2023
@tswast tswast enabled auto-merge (squash) March 29, 2023 18:35
@tswast tswast merged commit daa6852 into main Mar 29, 2023
@tswast tswast deleted the pandas-2.0 branch March 29, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support pandas 2.0
2 participants