Skip to content

PR to pandas #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tswast opened this issue Oct 13, 2021 · 3 comments
Closed

PR to pandas #30

tswast opened this issue Oct 13, 2021 · 3 comments
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Collaborator

tswast commented Oct 13, 2021

pandas devs are open to an experimental date/time dtype.

We'd still keep this package around to backport the types to older pandas.

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Oct 13, 2021
@tswast tswast added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Oct 13, 2021
@jorisvandenbossche
Copy link

jorisvandenbossche commented Oct 14, 2021

For date, the most relevant issue discussing this on the pandas side is pandas-dev/pandas#32473

Now, I think there are still some aspects to discuss / decide upon on how we would like to approach the actual storage. For example, what you are doing (using a datetime64 with midnight at zero) also has advantages versus storing the number of days since epoch (as using datetime64[D] would be. Eg the conversion date <-> timestamp becomes much cheaper.

@tswast
Copy link
Collaborator Author

tswast commented Oct 14, 2021

We did try datetime64[D] indeed it made the conversion to timestamp much more difficult. Also, I suspect adding time to date to get a timestamp will be a common operation, so datetime64[ns] was a better fit for that too.

@chalmerlowe
Copy link
Collaborator

Closing. Looking to deprecate this library at some point in the future by relying upon existing datatypes in pandas and python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants