Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in documentation on max_latency #507

Closed
kamalaboulhosn opened this issue Sep 27, 2021 · 0 comments · Fixed by #572
Closed

Inconsistency in documentation on max_latency #507

kamalaboulhosn opened this issue Sep 27, 2021 · 0 comments · Fixed by #572
Assignees
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. documentation Improvements or additions to documentation priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kamalaboulhosn
Copy link
Contributor

There is inconsistency in the documentation about the default value of max_latency. The publisher sample says it is 10ms. The batching documentation says it is 0.05s. Additionally, the batching documentation seems to lack any examples of how to set the other fields available. We should make sure that this documentation (and the documentation for whatever else we can set) is exhaustive.

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Sep 27, 2021
@meredithslota meredithslota added priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 27, 2021
@plamut plamut added the documentation Improvements or additions to documentation label Sep 27, 2021
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. documentation Improvements or additions to documentation priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants