Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return singleton success future for exactly-once methods in Message #608

Merged
merged 3 commits into from
Mar 9, 2022

Conversation

pradn
Copy link
Contributor

@pradn pradn commented Mar 8, 2022

This is a small change to return a singleton success future that's constructed once instead of making a new future every time for *_with_response methods. We don't want to guarantee that we'll always return a distinct future object. This issue was raised in googleapis/python-pubsublite#312.

@pradn pradn requested review from a team as code owners March 8, 2022 21:00
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 8, 2022
@pradn pradn changed the title Return singleton success future for exactly-once methods in Message feat: return singleton success future for exactly-once methods in Message Mar 8, 2022
Copy link

@mmicatka mmicatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@acocuzzo acocuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pradn pradn merged commit 253ced2 into googleapis:main Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants