Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exactly once delivery sample not using a subscription with exactly once delivery enabled #616

Closed
anguillanneuf opened this issue Mar 17, 2022 · 0 comments · Fixed by #619
Closed

Exactly once delivery sample not using a subscription with exactly once delivery enabled #616

anguillanneuf opened this issue Mar 17, 2022 · 0 comments · Fixed by #619
Assignees
@anguillanneuf
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@anguillanneuf
Copy link
Contributor

python-pubsub/samples/snippets/subscriber_test.py

Lines 652 to 657 in 8f02850

def test_receive_messages_with_exactly_once_delivery_enabled(
publisher_client: pubsub_v1.PublisherClient,
topic: str,
subscription_async: str,
capsys: CaptureFixture[str],
) -> None:

@product-auto-label product-auto-label bot added api: pubsub Issues related to the googleapis/python-pubsub API. samples Issues that are directly related to samples. labels Mar 17, 2022
@anguillanneuf anguillanneuf added type: cleanup An internal cleanup or hygiene concern. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed samples Issues that are directly related to samples. labels Mar 17, 2022
@anguillanneuf anguillanneuf self-assigned this Mar 17, 2022
@anguillanneuf anguillanneuf mentioned this issue Mar 18, 2022
Merged
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anguillanneuf anguillanneuf

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

samples(test): correct subscription type in exactly once delivery test googleapis/python-pubsub
1 participant
@anguillanneuf