-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reconsider calculation of time between leaser runs #675
Labels
api: pubsub
Issues related to the googleapis/python-pubsub API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Comments
product-auto-label
bot
added
the
api: pubsub
Issues related to the googleapis/python-pubsub API.
label
Apr 27, 2022
4 tasks
yoshi-automation
added
triage me
I really want to be triaged.
🚨
This issue needs some love.
labels
Apr 28, 2022
acocuzzo
added
the
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
label
May 4, 2022
4 tasks
4 tasks
acocuzzo
added
the
priority: p2
Moderately-important priority. Fix may not be included in next release.
label
May 4, 2022
yoshi-automation
removed
🚨
This issue needs some love.
triage me
I really want to be triaged.
labels
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the googleapis/python-pubsub API.
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
It's currently
random.uniform(0.0, ack_deadline * 0.9)
here.ack_deadline * 0.9
is to leave enough wiggle room so the lease requests can be sent and processed by the server before the previous leases expire. We should probably make sure this time allotted to request-sending/server-processing to be some reasonable minimum (like 50 ms). No point in leaving wiggle room if the acks are going to expire by the time the new lease modacks arrive at the server.This came up in the review of #662.
The text was updated successfully, but these errors were encountered: