Skip to content

fix: require google-cloud-core >= 1.4.4 #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 5, 2023
Merged

fix: require google-cloud-core >= 1.4.4 #223

merged 4 commits into from
Oct 5, 2023

Conversation

vchudnov-g
Copy link
Contributor

No description provided.

@vchudnov-g vchudnov-g requested a review from parthea October 5, 2023 18:06
@vchudnov-g vchudnov-g requested a review from a team as a code owner October 5, 2023 18:06
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: runtimeconfig Issues related to the googleapis/python-runtimeconfig API. size: u Pull request is empty. and removed size: xs Pull request size is extra small. labels Oct 5, 2023
@vchudnov-g
Copy link
Contributor Author

This is a manual library, so I'm not sure where "six" is coming from in the failing test.

@parthea
Copy link
Contributor

parthea commented Oct 5, 2023 •
edited
Loading

This is similar to googleapis/python-spanner#1014 where older versions of google-cloud-core have an undeclared dependency on six. One solution is to bump the minimum version of google-cloud-core to 1.4.4 as mentioned in the linked issue.

python-runtimeconfig/setup.py

Line 35 in b2297aa

"google-cloud-core >= 1.3.0, < 3.0dev",

@vchudnov-g
fix: Update google-cloud-core dependency
999699e 
This avoids implicit dependency on "six"
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: u Pull request is empty. labels Oct 5, 2023
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Oct 5, 2023
parthea
parthea reviewed Oct 5, 2023
View reviewed changes
testing/constraints-3.6.txt Outdated
# e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev",
# Then this file should have foo==1.14.0
google-cloud-core==1.3.0
google-cloud-core==1.4.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete testing/constraints-3.6.txt since the minimum supported runtime is python 3.7

python-runtimeconfig/setup.py

Line 87 in b2297aa

python_requires=">=3.7",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks!

@parthea parthea changed the title fix: Remove "six" dependency fix: require google-cloud-core >= 1.4.4 Oct 5, 2023
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Oct 5, 2023
@vchudnov-g vchudnov-g merged commit e695994 into main Oct 5, 2023
@vchudnov-g vchudnov-g deleted the remove-six branch October 5, 2023 21:41
@release-please release-please bot mentioned this pull request Oct 5, 2023
Merged
@vchudnov-g vchudnov-g changed the title fix: require google-cloud-core >= 1.4.4 fix: remove dependency on "six" Oct 5, 2023
@parthea parthea changed the title fix: remove dependency on "six" fix: require google-cloud-core >= 1.4.4 Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
api: runtimeconfig Issues related to the googleapis/python-runtimeconfig API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchudnov-g @parthea