fix: require google-cloud-core >= 1.4.4 #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xs
|
This is a manual library, so I'm not sure where "six" is coming from in the failing test. |
|
This is similar to googleapis/python-spanner#1014 where older versions of Line 35 in b2297aa |
This avoids implicit dependency on "six"
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: xs
parthea
reviewed
Oct 5, 2023
testing/constraints-3.6.txt
Outdated
| @@ -19,4 +19,4 @@ | |||
| # | |||
| # e.g., if setup.py has "foo >= 1.14.0, < 2.0.0dev", | |||
| # Then this file should have foo==1.14.0 | |||
| google-cloud-core==1.3.0 | |||
| google-cloud-core==1.4.4 | |||
There was a problem hiding this comment.
Delete testing/constraints-3.6.txt since the minimum supported runtime is python 3.7
Line 87 in b2297aa
There was a problem hiding this comment.
Good catch! Thanks!
parthea
changed the title
parthea
approved these changes
Oct 5, 2023
product-auto-label
bot
added
size: s
vchudnov-g
changed the title
parthea
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.