fix: don't introspect internal UNIQUE constraints #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
added
the
type: bug
product-auto-label
bot
added
the
api: spanner
asthamohta
approved these changes
Sep 5, 2022
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
IlyaFaer
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a foreign key created, Spanner adds a UNIQUE constraint for the column under the hood. As the dialect introspection method returns this constraint, new autogenerated migration is trying to delete the constraint.
I think here we should do the same we did for indexes - if a constraint is ruled automatically by Spanner, we should not allow the dialect to see it. Still,
information_schemadoesn't include the direct attribute showing the constraint is ruled automatically. Thus, we have to do aJOINto the table, where foreign keys are described, and see if this UNIQUE constraint is binded to a foreign key. If yes, we should hide it from the dialect to prevent Alembic from trying to delete it.Fixes #231